Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2351523002: X87: Record call counts also for megamorphic calls. (Closed)

Created:
4 years, 3 months ago by zhengxing.li
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Record call counts also for megamorphic calls. port 2ab3fcf42f0cf04896b26bf23bc3809d8835fd39(r39377) original commit message: To make better inlining decisions, it's good to have call counts for poly/mega-morphic cases. This CL makes it work for calls, and another will follow to better unify the code between constructor calls and normal calls (and thence, to record megamorphic call counts there as well). BUG= Committed: https://crrev.com/7368ce0c7ed1490c0dfd743edc44d08b07880a2f Cr-Commit-Position: refs/heads/master@{#39487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M src/x87/code-stubs-x87.cc View 8 chunks +22 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 3 months ago (2016-09-18 02:34:15 UTC) #2
Weiliang
lgtm
4 years, 3 months ago (2016-09-18 02:51:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351523002/1
4 years, 3 months ago (2016-09-18 02:57:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-18 03:23:21 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-18 03:23:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7368ce0c7ed1490c0dfd743edc44d08b07880a2f
Cr-Commit-Position: refs/heads/master@{#39487}

Powered by Google App Engine
This is Rietveld 408576698