Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 23515007: ARM: remove the regexp specific literal pool. (Closed)

Created:
7 years, 3 months ago by Rodolph Perfetta
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM: remove the regexp specific literal pool. It is replaced by a mov_label_offset(Register, Label*) instruction. BUG=none TEST=test/cctest/test-assembler-arm.cc R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -98 lines) Patch
M src/arm/assembler-arm.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/arm/assembler-arm.cc View 5 chunks +108 lines, -22 lines 0 comments Download
M src/arm/constants-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +9 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 3 chunks +1 line, -63 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rodolph Perfetta
Currently regexp literal pools are used to store offset only and their implementation potentially leaves ...
7 years, 3 months ago (2013-09-10 15:50:03 UTC) #1
Benedikt Meurer
LGTM.
7 years, 3 months ago (2013-09-12 07:09:44 UTC) #2
Rodolph Perfetta
7 years, 3 months ago (2013-09-12 10:38:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16676 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698