Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2351453002: [CUPS] Rename the Print Preview title from "Google Cloud Print" to "Google Print". (Closed)

Created:
4 years, 3 months ago by xdai1
Modified:
4 years, 3 months ago
Reviewers:
xiyuan, weifangsun
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Rename the Print Preview title from "Google Cloud Print" to "Google Print". BUG=646017, 626752 Committed: https://crrev.com/8879204dc2a16b103d68c70d57d25aa334386db7 Cr-Commit-Position: refs/heads/master@{#419821}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
xdai1
Weifang, please help review this CL, thanks!
4 years, 3 months ago (2016-09-17 00:29:38 UTC) #3
weifangsun
On 2016/09/17 00:29:38, xdai1 wrote: > Weifang, please help review this CL, thanks! Hi Daisy, ...
4 years, 3 months ago (2016-09-19 17:02:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351453002/20001
4 years, 3 months ago (2016-09-19 18:25:38 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-19 18:25:39 UTC) #9
xdai1
skau@, could you help review this CL please? Seems this file doesn't have a OWNER ...
4 years, 3 months ago (2016-09-19 18:57:07 UTC) #11
xdai1
Just remember that skau@ will be OOO for the following two weeks. xiyuan@, could you ...
4 years, 3 months ago (2016-09-20 17:39:11 UTC) #13
xiyuan
lgtm
4 years, 3 months ago (2016-09-20 17:41:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351453002/20001
4 years, 3 months ago (2016-09-20 17:47:04 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-20 18:33:47 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 18:35:23 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8879204dc2a16b103d68c70d57d25aa334386db7
Cr-Commit-Position: refs/heads/master@{#419821}

Powered by Google App Engine
This is Rietveld 408576698