|
|
Chromium Code Reviews
Description[CUPS] Rename the Print Preview title from "Google Cloud Print" to "Google Print".
BUG=646017, 626752
Committed: https://crrev.com/8879204dc2a16b103d68c70d57d25aa334386db7
Cr-Commit-Position: refs/heads/master@{#419821}
Patch Set 1 : . #
Messages
Total messages: 20 (10 generated)
Description was changed from ========== [CUPS] Rename the Print Preview title from "Google Cloud Print" to "Google Print". BUG=646017 ========== to ========== [CUPS] Rename the Print Preview title from "Google Cloud Print" to "Google Print". BUG=646017, 626752 ==========
xdai@chromium.org changed reviewers: + weifangsun@chromium.org
Weifang, please help review this CL, thanks!
On 2016/09/17 00:29:38, xdai1 wrote: > Weifang, please help review this CL, thanks! Hi Daisy, this looks good to me!! Thanks!
Patchset #1 (id:1) has been deleted
The CQ bit was checked by xdai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
xdai@chromium.org changed reviewers: + skau@chromium.org
skau@, could you help review this CL please? Seems this file doesn't have a OWNER but I still need the approval from a committer. Thanks!
xdai@chromium.org changed reviewers: + xiyuan@chromium.org - skau@chromium.org
Just remember that skau@ will be OOO for the following two weeks. xiyuan@, could you help review this small CL please? Seems this file doesn't have a OWNER but I still need the approval from a full committer. Thanks!
lgtm
The CQ bit was checked by xdai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [CUPS] Rename the Print Preview title from "Google Cloud Print" to "Google Print". BUG=646017, 626752 ========== to ========== [CUPS] Rename the Print Preview title from "Google Cloud Print" to "Google Print". BUG=646017, 626752 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [CUPS] Rename the Print Preview title from "Google Cloud Print" to "Google Print". BUG=646017, 626752 ========== to ========== [CUPS] Rename the Print Preview title from "Google Cloud Print" to "Google Print". BUG=646017, 626752 Committed: https://crrev.com/8879204dc2a16b103d68c70d57d25aa334386db7 Cr-Commit-Position: refs/heads/master@{#419821} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8879204dc2a16b103d68c70d57d25aa334386db7 Cr-Commit-Position: refs/heads/master@{#419821} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
