Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2351443003: Revert of Show ancestor hierarchy in accessibility panel (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
dmazzoni, dgozman, aboxhall, vinodsonkusare77, pfeldman
CC:
dmazzoni, aboxhall+watch_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-wtf_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, haraken, je_julie, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, Mikhail, nektarios, nektar+watch_chromium.org, pfeldman, pfeldman+blink_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show ancestor hierarchy in accessibility panel (patchset #10 id:180001 of https://codereview.chromium.org/2322413003/ ) Reason for revert: Fails the compile step on Linux ChromiumOS GN (headless_unittests) Original issue's description: > Show ancestor hierarchy in accessibility panel > > BUG=560525 > > Committed: https://crrev.com/3558706c1b2a630557929b61fefc74e28975f3a6 > Cr-Commit-Position: refs/heads/master@{#419369} TBR=dmazzoni@chromium.org,dgozman@chromium.org,pfeldman@chromium.org,aboxhall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=560525 Committed: https://crrev.com/3c3a44090a7413137f129c86a0da7ac11b9ad620 Cr-Commit-Position: refs/heads/master@{#419371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6399 lines, -7016 lines) Patch
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-dumpAccessibilityNodes.js View 3 chunks +8 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getAXNode.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getAXNode-expected.txt View 1 chunk +55 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getAXNodeWithAncestors.html View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getAXNodeWithAncestors-expected.txt View 1 chunk +0 lines, -169 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getNodeWithNoAXNode.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getNodeWithNoAXNode-expected.txt View 1 chunk +12 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getRelationships-expected.txt View 3 chunks +120 lines, -124 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt View 1 chunk +423 lines, -453 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal-expected.txt View 1 chunk +72 lines, -78 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-buttons-expected.txt View 1 chunk +586 lines, -608 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-img-figure-expected.txt View 3 chunks +660 lines, -684 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input-buttons-expected.txt View 2 chunks +1313 lines, -1349 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input-expected.txt View 2 chunks +971 lines, -993 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-labelledby-expected.txt View 13 chunks +1221 lines, -1257 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-summary-expected.txt View 2 chunks +247 lines, -255 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-visiblity-expected.txt View 8 chunks +653 lines, -671 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js View 1 chunk +0 lines, -131 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js View 1 chunk +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 3 chunks +11 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/accessibilityNode.css View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/module.json View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 5 chunks +26 lines, -34 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
fs
Created Revert of Show ancestor hierarchy in accessibility panel
4 years, 3 months ago (2016-09-17 19:20:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351443003/1
4 years, 3 months ago (2016-09-17 19:20:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-17 19:22:04 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3c3a44090a7413137f129c86a0da7ac11b9ad620 Cr-Commit-Position: refs/heads/master@{#419371}
4 years, 3 months ago (2016-09-17 19:23:48 UTC) #6
aboxhall
Any chance of a link to the failing build? On Sat, Sep 17, 2016 at ...
4 years, 3 months ago (2016-09-18 14:23:47 UTC) #7
aboxhall
Any chance of a link to the failing build? On Sat, Sep 17, 2016 at ...
4 years, 3 months ago (2016-09-18 14:23:47 UTC) #8
fs
On 2016/09/18 at 14:23:47, aboxhall wrote: > Any chance of a link to the failing ...
4 years, 3 months ago (2016-09-18 16:18:57 UTC) #9
vinodsonkusare77_gmail.com
https://youtu.be/ZB29OFBS2w8 On Sun, Sep 18, 2016 at 12:50 AM, <fs@opera.com> wrote: > Reviewers: dmazzoni, dgozman, ...
4 years, 3 months ago (2016-09-19 05:00:30 UTC) #10
vinodsonkusare77_gmail.com
https://youtu.be/ZB29OFBS2w8 On Sun, Sep 18, 2016 at 12:50 AM, <fs@opera.com> wrote: > Reviewers: dmazzoni, dgozman, ...
4 years, 3 months ago (2016-09-19 05:00:31 UTC) #11
vinodsonkusare77_gmail.com
https://youtu.be/yD6KioQhnAc On Mon, Sep 19, 2016 at 10:30 AM, Vinod kumar Sonkusare < vinodsonkusare77@gmail.com> wrote: ...
4 years, 3 months ago (2016-09-19 05:00:52 UTC) #12
vinodsonkusare77_gmail.com
4 years, 3 months ago (2016-09-19 05:00:53 UTC) #13
Message was sent while issue was closed.
https://youtu.be/yD6KioQhnAc

On Mon, Sep 19, 2016 at 10:30 AM, Vinod kumar Sonkusare <
vinodsonkusare77@gmail.com> wrote:

> https://youtu.be/ZB29OFBS2w8
>
> On Sun, Sep 18, 2016 at 12:50 AM, <fs@opera.com> wrote:
>
>> Reviewers: dmazzoni, dgozman, pfeldman, aboxhall
>> CL: https://codereview.chromium.org/2351443003/
>>
>> Message:
>> Created Revert of Show ancestor hierarchy in accessibility panel
>>
>> Description:
>> Revert of Show ancestor hierarchy in accessibility panel (patchset #10
>> id:180001
>> of https://codereview.chromium.org/2322413003/ )
>>
>> Reason for revert:
>> Fails the compile step on Linux ChromiumOS GN (headless_unittests)
>>
>> Original issue's description:
>> > Show ancestor hierarchy in accessibility panel
>> >
>> > BUG=560525
>> >
>> > Committed: https://crrev.com/3558706c1b2a630557929b61fefc74e28975f3a6
>> > Cr-Commit-Position: refs/heads/master@{#419369}
>>
>> TBR=dmazzoni@chromium.org,dgozman@chromium.org,pfeldman@chro
>> mium.org,aboxhall@chromium.org
>> # Skipping CQ checks because original CL landed less than 1 days ago.
>> NOPRESUBMIT=true
>> NOTREECHECKS=true
>> NOTRY=true
>> BUG=560525
>>
>> Affected files (+6399, -7016 lines):
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-dumpAccessibilityNodes.js
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-getAXNode.html
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-getAXNode-expected.txt
>> D third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-getAXNodeWithAncestors.html
>> D third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-getAXNodeWithAncestors-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-getNodeWithNoAXNode.html
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-getNodeWithNoAXNode-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-getRelationships-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-ignoredNodes-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-ignoredNodesModal-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-nameSources-buttons-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-nameSources-img-figure-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-nameSources-input-buttons-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-nameSources-input-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-nameSources-labelledby-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-nameSources-summary-expected.txt
>> M third_party/WebKit/LayoutTests/inspector-protocol/
>> accessibility/accessibility-nameSources-visiblity-expected.txt
>> M third_party/WebKit/Source/core/inspector/browser_protocol.json
>> M third_party/WebKit/Source/devtools/BUILD.gn
>> D third_party/WebKit/Source/devtools/front_end/accessibility/
>> AXTreePane.js
>> M third_party/WebKit/Source/devtools/front_end/accessibility/A
>> ccessibilityModel.js
>> M third_party/WebKit/Source/devtools/front_end/accessibility/A
>> ccessibilitySidebarView.js
>> M third_party/WebKit/Source/devtools/front_end/accessibility/a
>> ccessibilityNode.css
>> M third_party/WebKit/Source/devtools/front_end/accessibility/module.json
>> M third_party/WebKit/Source/modules/accessibility/InspectorAcc
>> essibilityAgent.h
>> M third_party/WebKit/Source/modules/accessibility/InspectorAcc
>> essibilityAgent.cpp
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "DevTools Reviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to devtools-reviews+unsubscribe@chromium.org.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698