Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2351423002: Fix DCHECK usage doc comment. (Closed)

Created:
4 years, 3 months ago by pwnall
Modified:
4 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK usage doc comment. BUG= Committed: https://crrev.com/7ae42b469da272a253766545ddfa604063aab4d4 Cr-Commit-Position: refs/heads/master@{#420242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/logging.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
pwnall
PTAL? 1) If I understand the code correctly, the DCHECK implementation adds a ". " ...
4 years, 3 months ago (2016-09-21 00:30:45 UTC) #1
pwnall
PTAL? 1) If I understand the code correctly, the DCHECK implementation adds a ". " ...
4 years, 3 months ago (2016-09-21 00:33:01 UTC) #3
danakj
LGTM
4 years, 3 months ago (2016-09-21 23:06:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351423002/1
4 years, 3 months ago (2016-09-21 23:07:46 UTC) #6
pwnall
On 2016/09/21 23:06:38, danakj wrote: > LGTM Thank you very much for the quick review!
4 years, 3 months ago (2016-09-21 23:40:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 02:26:31 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 02:28:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ae42b469da272a253766545ddfa604063aab4d4
Cr-Commit-Position: refs/heads/master@{#420242}

Powered by Google App Engine
This is Rietveld 408576698