Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23514051: various bug fixes. (Closed)

Created:
7 years, 3 months ago by djsollen
Modified:
7 years, 3 months ago
Reviewers:
borenet, mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

various bug fixes. 1. update mac support for md5 2. update default build to be thumb (SkipBuildbotRuns) R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=11201

Patch Set 1 #

Total comments: 2

Patch Set 2 : bug fix #

Patch Set 3 : skip buildbots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M platform_tools/android/bin/android_setup.sh View 1 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
7 years, 3 months ago (2013-09-11 14:30:51 UTC) #1
mtklein
https://codereview.chromium.org/23514051/diff/1/platform_tools/android/bin/android_setup.sh File platform_tools/android/bin/android_setup.sh (right): https://codereview.chromium.org/23514051/diff/1/platform_tools/android/bin/android_setup.sh#newcode268 platform_tools/android/bin/android_setup.sh:268: HOST_MD5=`md5 -q $HOST_SRC` DST became SRC?
7 years, 3 months ago (2013-09-11 15:01:59 UTC) #2
djsollen
https://codereview.chromium.org/23514051/diff/1/platform_tools/android/bin/android_setup.sh File platform_tools/android/bin/android_setup.sh (right): https://codereview.chromium.org/23514051/diff/1/platform_tools/android/bin/android_setup.sh#newcode268 platform_tools/android/bin/android_setup.sh:268: HOST_MD5=`md5 -q $HOST_SRC` On 2013/09/11 15:02:00, mtklein wrote: > ...
7 years, 3 months ago (2013-09-11 16:26:59 UTC) #3
mtklein
lgtm Weirdly, my laptop has both md5 and md5sum.
7 years, 3 months ago (2013-09-11 16:36:57 UTC) #4
djsollen
7 years, 3 months ago (2013-09-11 17:00:18 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r11201.

Powered by Google App Engine
This is Rietveld 408576698