Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Issue 23514047: Fix for ovals failing on Xoom. (Closed)

Created:
7 years, 3 months ago by jvanverth1
Modified:
7 years, 3 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix for ovals failing on Xoom. The fallback path for ellipses when we don't have GLSL derivative instructions was only setting one attribute in the effect stage, but we use two attributes. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=11184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/gpu/GrOvalRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jvanverth1
7 years, 3 months ago (2013-09-10 18:21:52 UTC) #1
robertphillips
lgtm
7 years, 3 months ago (2013-09-10 18:22:37 UTC) #2
jvanverth1
7 years, 3 months ago (2013-09-10 18:24:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r11184.

Powered by Google App Engine
This is Rietveld 408576698