Issue 23514043: file_manager: Remove unused fields from DriveEntryProperties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23514043: file_manager: Remove unused fields from DriveEntryProperties (Closed)

Created:
7 years, 3 months ago by satorux1

Modified:
7 years, 3 months ago

Reviewers:
yoshiki, benwells

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: Remove unused fields from DriveEntryProperties "fileUrl" and "errorCode" are no longer in use. BUG=257916 TEST=Files.app works as before R=benwells@chromium.org, yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221977

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -13 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc	View		2 chunks	+0 lines, -3 lines	0 comments	Download
	M	chrome/common/extensions/api/file_browser_private.json	View		2 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

satorux1

7 years, 3 months ago (2013-09-09 06:15:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r221977 (presubmit successful).

Expand Messages | Collapse Messages