Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23514035: Add preprocessor to reloadOptions in chrome.devtools.inspectedWindow.reload(). (Closed)

Created:
7 years, 3 months ago by johnjbarton
Modified:
7 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add preprocessor to reloadOptions in chrome.devtools.inspectedWindow.reload(). Add options.preprocessor to ExtensionServer.js. Add test case to extensions-reload.html to verify preprocessingScript is run. BUG=229971 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157318

Patch Set 1 #

Patch Set 2 : remove blank lines #

Patch Set 3 : rebase #

Patch Set 4 : Now without my file system directories... #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M LayoutTests/inspector/extensions/extensions-reload.html View 1 2 3 2 chunks +34 lines, -1 line 0 comments Download
M LayoutTests/inspector/extensions/extensions-reload-expected.txt View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download
M Source/devtools/front_end/ExtensionServer.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/externs.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
johnjbarton
Ready for review. This is a retry https://codereview.chromium.org/13816005/ after revised preprocessor landed.
7 years, 3 months ago (2013-09-03 18:33:04 UTC) #1
pfeldman
lgtm
7 years, 3 months ago (2013-09-04 15:28:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnjbarton@chromium.org/23514035/3001
7 years, 3 months ago (2013-09-04 15:36:58 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3960
7 years, 3 months ago (2013-09-04 17:46:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnjbarton@chromium.org/23514035/21001
7 years, 3 months ago (2013-09-04 18:32:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3982
7 years, 3 months ago (2013-09-04 20:02:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnjbarton@chromium.org/23514035/35001
7 years, 3 months ago (2013-09-04 21:23:57 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=4260
7 years, 3 months ago (2013-09-05 02:20:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnjbarton@chromium.org/23514035/52001
7 years, 3 months ago (2013-09-05 17:58:01 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 19:06:52 UTC) #10
Message was sent while issue was closed. 
Change committed as 157318

Powered by Google App Engine
This is Rietveld 408576698