Evaluation of expression in context of library top-level

runtime/bin/dbg_message.cc

Index: runtime/bin/dbg_message.cc
===================================================================
--- runtime/bin/dbg_message.cc	(revision 26817)
+++ runtime/bin/dbg_message.cc	(working copy)
@@ -648,9 +648,8 @@
   Dart_Handle target;
 
   if (msg_parser.HasParam("libraryId")) {

[Ivan Posva, 2013/08/29 23:12:32]

What will happen if a message has a "libraryId", a "classId" and an "objectId"?

[hausner, 2013/08/29 23:34:47]

The protocol does not allow that, but if the client sends a message like this
the libraryId wins since I happen to test for that first here.

-    in_msg->SendErrorReply(msg_id,
-                           "libararyId evaluation target not supported");
-    return false;
+    intptr_t lib_id = msg_parser.GetIntParam("libraryId");
+    target = Dart_GetLibraryFromId(lib_id);
   } else if (msg_parser.HasParam("classId")) {
     intptr_t cls_id = msg_parser.GetIntParam("classId");
     target = Dart_GetClassFromId(cls_id);