runtime/bin/dbg_message.cc - Issue 23514020: Evaluation of expression in context of library top-level

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/dbg_message.cc

Issue 23514020: Evaluation of expression in context of library top-level (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/dbg_message.cc

===================================================================

--- runtime/bin/dbg_message.cc (revision 26897)

+++ runtime/bin/dbg_message.cc (working copy)

@@ -648,9 +648,8 @@

Dart_Handle target;

if (msg_parser.HasParam("libraryId")) {

- in_msg->SendErrorReply(msg_id,

- "libararyId evaluation target not supported");

- return false;

+ intptr_t lib_id = msg_parser.GetIntParam("libraryId");

+ target = Dart_GetLibraryFromId(lib_id);

} else if (msg_parser.HasParam("classId")) {

intptr_t cls_id = msg_parser.GetIntParam("classId");

target = Dart_GetClassFromId(cls_id);

« no previous file with comments | « no previous file | runtime/include/dart_debugger_api.h » ('j') | no next file with comments »