Issue 23514009: Fix escape analysis for redefining operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23514009: Fix escape analysis for redefining operators. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix escape analysis for redefining operators. This recognizes escape paths that flow through informative definitions as an escaping use. This only applies to HCheckMaps so far. R=hpayer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16420

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -12 lines)			Patch
	M	src/hydrogen-escape-analysis.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/hydrogen-escape-analysis.cc	View		2 chunks	+19 lines, -11 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

lgtm https://codereview.chromium.org/23514009/diff/1/src/hydrogen-escape-analysis.cc File src/hydrogen-escape-analysis.cc (right): https://codereview.chromium.org/23514009/diff/1/src/hydrogen-escape-analysis.cc#newcode64 src/hydrogen-escape-analysis.cc:64: PrintF("#%d (%s) is being captured\n", instr->id(), may fit ...

7 years, 3 months ago (2013-08-29 11:53:29 UTC) #2

Michael Starzinger

Landing. https://codereview.chromium.org/23514009/diff/1/src/hydrogen-escape-analysis.cc File src/hydrogen-escape-analysis.cc (right): https://codereview.chromium.org/23514009/diff/1/src/hydrogen-escape-analysis.cc#newcode64 src/hydrogen-escape-analysis.cc:64: PrintF("#%d (%s) is being captured\n", instr->id(), On 2013/08/29 ...

7 years, 3 months ago (2013-08-29 11:54:39 UTC) #3

Michael Starzinger

7 years, 3 months ago (2013-08-29 11:55:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r16420 (presubmit successful).

Expand Messages | Collapse Messages