Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2351393003: [base] Revert "Move hashmap allocator to a field" (Closed)

Created:
4 years, 3 months ago by Leszek Swirski
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[base] Revert "Move hashmap allocator to a field" This reverts commit b42ecda533bd53ddc17f55e256236f23253382b8. That commit introduced a allocator field to hashmap, which indirectly added a field to Scopes, where the field, effectively storing a Zone, is unnecessary because the Zone can be accessed in other ways. Committed: https://crrev.com/b81cddc57f1ce2a098adfe477e79a820aace68de Cr-Commit-Position: refs/heads/master@{#39623}

Patch Set 1 #

Patch Set 2 : Whoops, patch sets should build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -60 lines) Patch
M src/asmjs/asm-typer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/asmjs/asm-wasm-builder.cc View 6 chunks +12 lines, -8 lines 0 comments Download
M src/ast/ast.h View 1 3 chunks +6 lines, -4 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/scopes.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/ast/scopes.cc View 1 5 chunks +13 lines, -10 lines 0 comments Download
M src/base/hashmap.h View 9 chunks +30 lines, -26 lines 0 comments Download
M src/compiler/state-values-utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen-bce.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Leszek Swirski
ahaas@chromium.org: Please review changes in verwaest@chromium.org: Please review changes in bmeurer@chromium.org: Please review changes in
4 years, 3 months ago (2016-09-21 10:55:40 UTC) #2
Toon Verwaest
lgtm, thanks
4 years, 3 months ago (2016-09-21 11:22:15 UTC) #9
ahaas
On 2016/09/21 at 11:22:15, verwaest wrote: > lgtm, thanks asmjs lgtm
4 years, 3 months ago (2016-09-21 11:23:16 UTC) #10
Benedikt Meurer
LGTM
4 years, 3 months ago (2016-09-22 11:05:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351393003/20001
4 years, 3 months ago (2016-09-22 11:06:07 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 11:08:28 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 11:09:05 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b81cddc57f1ce2a098adfe477e79a820aace68de
Cr-Commit-Position: refs/heads/master@{#39623}

Powered by Google App Engine
This is Rietveld 408576698