Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 2351373003: Add methods in spdy/quic session to get stream id of pushed stream given the request url (Closed)

Created:
4 years, 3 months ago by Zhongyi Shi
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add methods in spdy/quic session to get stream id of pushed stream given the request url BUG=232040 Committed: https://crrev.com/96d0202cee58e8165e100e996b7936ec538a11d0 Cr-Commit-Position: refs/heads/master@{#420574}

Patch Set 1 #

Total comments: 5

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M net/quic/chromium/quic_chromium_client_session.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Zhongyi Shi
4 years, 3 months ago (2016-09-21 00:17:41 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/2351373003/diff/1/net/quic/chromium/quic_chromium_client_session.h File net/quic/chromium/quic_chromium_client_session.h (right): https://codereview.chromium.org/2351373003/diff/1/net/quic/chromium/quic_chromium_client_session.h#newcode238 net/quic/chromium/quic_chromium_client_session.h:238: // Else return 0. nit: // Returns the ...
4 years, 2 months ago (2016-09-22 21:41:33 UTC) #3
Zhongyi Shi
https://codereview.chromium.org/2351373003/diff/1/net/quic/chromium/quic_chromium_client_session.h File net/quic/chromium/quic_chromium_client_session.h (right): https://codereview.chromium.org/2351373003/diff/1/net/quic/chromium/quic_chromium_client_session.h#newcode238 net/quic/chromium/quic_chromium_client_session.h:238: // Else return 0. On 2016/09/22 21:41:33, Ryan Hamilton ...
4 years, 2 months ago (2016-09-22 22:57:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351373003/20001
4 years, 2 months ago (2016-09-22 22:57:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/229128) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 2 months ago (2016-09-23 00:59:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351373003/20001
4 years, 2 months ago (2016-09-23 03:45:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-23 04:11:11 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 04:12:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96d0202cee58e8165e100e996b7936ec538a11d0
Cr-Commit-Position: refs/heads/master@{#420574}

Powered by Google App Engine
This is Rietveld 408576698