Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 2351373002: Fix debug break on assignment to global variable (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index 92a2903b22acf73e1950c5a33e5c2a2097cbf1bd..b615941fad16b51c183160cc2be077fe32b79e9e 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -3708,9 +3708,13 @@ Definition* EffectGraphVisitor::BuildStoreStaticField(
// If the right hand side is an expression that does not contain
// a safe point for the debugger to stop, add an explicit stub
// call.
- if ((node->value()->IsLiteralNode() ||
- node->value()->IsLoadLocalNode() ||
- node->value()->IsClosureNode()) &&
+ AstNode* val = node->value();
+ if (val->IsAssignableNode()) {
+ val = val->AsAssignableNode()->expr();
+ }
+ if ((val->IsLiteralNode() ||
+ val->IsLoadLocalNode() ||
+ val->IsClosureNode()) &&
node->token_pos().IsDebugPause()) {
AddInstruction(new(Z) DebugStepCheckInstr(
node->token_pos(), RawPcDescriptors::kRuntimeCall));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698