MD History: Update button style for CBD in sidenav

chrome/browser/resources/md_history/side_bar.html

 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys-behavior/iron-a11y-keys-behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-selector.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripple.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/typography.html">
 <link rel="import" href="chrome://history/browser_service.html">
 <link rel="import" href="chrome://history/shared_style.html">
 
 <dom-module id="history-side-bar">
   <template>
     <style include="shared-style">
       :host {
         display: block;
         height: 100%;
         padding-top: 5px;
         width: var(--side-bar-width);
       }
 
       div.separator {
         background-color: rgba(0, 0, 0, 0.08);
         height: 1px;
         margin: 8px 0;
       }
 
       #clear-browsing-data {
-        text-transform: uppercase;
+        justify-content: space-between;
+      }
+
+      #clear-browsing-data-icon {

[tsergeant, 2016/09/21 23:51:47]

Nit: Remove the id from the icon and use the selector

#clear-browsing-data iron-icon

instead

[lshang, 2016/09/22 04:47:13]

Done.

+        color: var(--paper-grey-400);
+        margin: 20px 48px 20px 0;

[tsergeant, 2016/09/21 23:51:47]

I think the sizes in the mock were for 2x screens: It matches the preview image
more closely if you halve them to 10px 24px 10px 0;

Also, all our icons are 20px by 20px, so add:

height: 20px;
width: 20px;

here

[Dan Beam, 2016/09/22 00:14:39]

this probably wont work in TRL

[lshang, 2016/09/22 04:47:13]

Done. I saw the more-vert-button in history item is 24px by 24px, chose the
wrong icon as referrence :P

[lshang, 2016/09/22 04:47:13]

I added 24px margin to both left and right, in case in right-to-left mode. Is
that OK?

[tsergeant, 2016/09/22 06:34:30]

I think it would be better to use -webkit-margin-end to set the margin. This
leaves more space on the left side for translated text, which can be longer than
English text.

[lshang, 2016/09/22 07:27:07]

Done.

[Dan Beam, 2016/09/23 06:22:30]

yes

       }
 
       iron-selector {
         -webkit-user-select: none;
         background-color: transparent;
         color: #5a5a5a;
       }
 
       iron-selector > a {
         @apply(--paper-font-subhead);
@@ skipping 51 matching lines @@
       </a>
       <a href="/syncedTabs[[getQueryString_(route)]]" class="page-item"
           path="syncedTabs">
         $i18n{openTabsMenuItem}
         <paper-ripple></paper-ripple>
       </a>
       <div class="separator"></div>
       <a href="chrome://settings/clearBrowserData"
           on-tap="onClearBrowsingDataTap_" id="clear-browsing-data">
         $i18n{clearBrowsingData}
+        <iron-icon icon="history:open-in-new" id="clear-browsing-data-icon"></iron-icon>

[Dan Beam, 2016/09/22 00:14:39]

80 char wrap

[lshang, 2016/09/22 04:47:13]

NaN after remove the id XD

         <paper-ripple id="cbd-ripple"></paper-ripple>
       </a>
       <div id="footer" hidden="[[!showFooter]]">
         <div class="separator"></div>
         <div id="footer-text">$i18nRaw{sidebarFooter}</div>
       </div>
     </iron-selector>
   </template>
   <script src="chrome://history/side_bar.js"></script>
 </dom-module>