Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2351353002: Update WebUILogin Focus for Mash (Closed)

Created:
4 years, 3 months ago by jonross
Modified:
4 years, 3 months ago
Reviewers:
xiyuan, sky
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, James Cook
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WebUILogin Focus for Mash There is no ash::Shell instance when running in mash, the new focus code in WebUILogin does not work. Exit early in newly added code to allow for login to not crash while running in mash. TEST=manual BUG=647039 Committed: https://crrev.com/2c5fa0e91fb3fcd0b480856104a793ca3219cca1 Cr-Commit-Position: refs/heads/master@{#419855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jonross
Hey sky@, jamescook@ is seeing a crash in login, this addresses it. Could you provide ...
4 years, 3 months ago (2016-09-20 20:39:12 UTC) #2
jonross
Hey sky@, jamescook@ is seeing a crash in login, this addresses it. Could you provide ...
4 years, 3 months ago (2016-09-20 20:39:14 UTC) #3
xiyuan
lgtm Thanks for taking care of it.
4 years, 3 months ago (2016-09-20 20:54:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351353002/1
4 years, 3 months ago (2016-09-20 20:56:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 21:20:37 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 21:22:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c5fa0e91fb3fcd0b480856104a793ca3219cca1
Cr-Commit-Position: refs/heads/master@{#419855}

Powered by Google App Engine
This is Rietveld 408576698