Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23513083: Fix the adb_gdb script to honor the --gdb flag for a user specified gdb binary according to the exi… (Closed)

Created:
7 years, 3 months ago by atreat
Modified:
7 years, 2 months ago
Reviewers:
digit1, eseidel
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, Peter Beverloo, bulach
Base URL:
https://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix the adb_gdb script to honor the --gdb flag for a user specified gdb binary according to the existing usage. BUG=295807 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M build/android/adb_gdb View 4 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
atreat
7 years, 3 months ago (2013-09-20 19:16:08 UTC) #1
eseidel
7 years, 2 months ago (2013-09-30 18:24:13 UTC) #2
digit1
lgtm. Thanks :)
7 years, 2 months ago (2013-09-30 20:08:40 UTC) #3
atreat
On 2013/09/30 20:08:40, digit1 wrote: > lgtm. Thanks :) Ping. CQ?
7 years, 2 months ago (2013-10-01 23:18:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/23513083/1
7 years, 2 months ago (2013-10-01 23:20:37 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-02 00:18:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/23513083/1
7 years, 2 months ago (2013-10-02 00:59:23 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-02 01:49:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/23513083/1
7 years, 2 months ago (2013-10-02 17:28:34 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 18:56:37 UTC) #10
Message was sent while issue was closed. 
Change committed as 226514

Powered by Google App Engine
This is Rietveld 408576698