Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: Source/bindings/v8/ScriptValue.cpp

Issue 23513066: Pass isolate to ScriptPromise and ScriptString constructors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptValue.h ('k') | Source/core/inspector/ScriptArguments.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptValue.cpp
diff --git a/Source/bindings/v8/ScriptValue.cpp b/Source/bindings/v8/ScriptValue.cpp
index 6a2e35355277eb416f79777cdcb5b42d1ea62ba9..4926ed9a811a0fe6517f7957b16b70800269dfba 100644
--- a/Source/bindings/v8/ScriptValue.cpp
+++ b/Source/bindings/v8/ScriptValue.cpp
@@ -62,12 +62,12 @@ ScriptValue ScriptValue::deserialize(ScriptState* scriptState, SerializedScriptV
return ScriptValue(value->deserialize(), scriptState->isolate());
}
-bool ScriptValue::getString(String& result, v8::Isolate* isolate) const
+bool ScriptValue::getString(String& result) const
{
if (hasNoValue())
return false;
- v8::HandleScope handleScope(isolate);
+ v8::HandleScope handleScope(m_isolate);
v8::Handle<v8::Value> string = v8Value();
if (string.IsEmpty() || !string->IsString())
return false;
@@ -75,7 +75,7 @@ bool ScriptValue::getString(String& result, v8::Isolate* isolate) const
return true;
}
-String ScriptValue::toString(ScriptState*) const
+String ScriptValue::toString() const
{
v8::TryCatch block;
v8::Handle<v8::String> string = v8Value()->ToString();
« no previous file with comments | « Source/bindings/v8/ScriptValue.h ('k') | Source/core/inspector/ScriptArguments.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698