Issue 23513062: Add flags to force or prevent setting of isolate.is_memory_constrained.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23513062: Add flags to force or prevent setting of isolate.is_memory_constrained. (Closed)

Created:
7 years, 3 months ago by rmcilroy

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add flags to force or prevent setting of isolate.is_memory_constrained. Enables MAYBE_BOOL flags for when you want to only do something if the flag was explicitly set to true or false. Also cleans up JSArguments struct. BUG=None R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16774

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -49 lines)			Patch
M	src/api.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/d8.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/flag-definitions.h	View	1	7 chunks	+28 lines, -28 lines	1 comment	Download
M	src/flags.cc	View		13 chunks	+30 lines, -7 lines	0 comments	Download
M	src/isolate.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	test/cctest/test-flags.cc	View		12 chunks	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM, I'll land it for you. https://codereview.chromium.org/23513062/diff/3001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/23513062/diff/3001/src/flag-definitions.h#newcode108 src/flag-definitions.h:108: int argc; Let's ...

7 years, 3 months ago (2013-09-17 13:46:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r16774.

Expand Messages | Collapse Messages