Issue 23513057: Add missing POST method to popup test HTML

Issue 23513057: Add missing POST method to popup test HTML (Closed)

Created:
7 years, 3 months ago by joth

Modified:
7 years, 3 months ago

Reviewers:
Kristian Monsen

CC:
chromium-reviews, Johnny(Jianning) Ding

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add missing POST method to popup test HTML This is a pre-requisite for crbug.com/291747 / crrev.com/23526048 as with that get request will have query param appended even when the target is data: Also the test states it is doing a POST so this actually makes it so. Landing as its own patch as trybots don't like my attempts to send CRLF edits in patches. NOTRY=true BUG=291747 R=kristianm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223266

Patch Set 1 #

Patch Set 2 : no CRLF fixup #

Patch Set 3 : again #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/test/data/popup_blocker/popup-blocked-to-post-blank.html	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/23513057/2

7 years, 3 months ago (2013-09-14 22:40:15 UTC) #3

commit-bot: I haz the power

Failed to apply patch for chrome/test/data/popup_blocker/popup-blocked-to-post-blank.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

7 years, 3 months ago (2013-09-14 22:40:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/23513057/8001

7 years, 3 months ago (2013-09-14 22:51:22 UTC) #5

commit-bot: I haz the power

Failed to apply patch for chrome/test/data/popup_blocker/popup-blocked-to-post-blank.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

7 years, 3 months ago (2013-09-14 22:51:23 UTC) #6

joth

Committed patchset #3 manually as r223266 (presubmit successful).

7 years, 3 months ago (2013-09-14 22:54:02 UTC) #7

joth

7 years, 3 months ago (2013-09-14 23:31:39 UTC) #8

Message was sent while issue was closed.

On 2013/09/14 22:54:02, joth wrote:
> Committed patchset #3 manually as r223266 (presubmit successful).

FTR this was specifically to fix
PopupBlockerBrowserTest.UnblockedPopupShowsInHistoryAndOmnibox

Expand Messages | Collapse Messages