Populate canPlayType to renderer

chrome/browser/media/encrypted_media_message_filter_android.cc

Index: chrome/browser/media/encrypted_media_message_filter_android.cc
diff --git a/chrome/browser/media/encrypted_media_message_filter_android.cc b/chrome/browser/media/encrypted_media_message_filter_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..40ec0bc2af327ec100b34171ba0bb8fedb4fdf25
--- /dev/null
+++ b/chrome/browser/media/encrypted_media_message_filter_android.cc
@@ -0,0 +1,79 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/encrypted_media_message_filter_android.h"
+
+#include <string>
+
+#include "chrome/common/encrypted_media_messages_android.h"
+#include "chrome/common/widevine_cdm_constants.h"

[ddorwin, 2013/09/17 22:29:08]

We shouldn't include a widevine file here.

This CL takes constants used only for Widevine, moves them to a Widevine file,
then uses them generically (for any uuid). To avoid this and layering
violations, we may want to duplicate the enum (with an appropriate compile
assert where they intersect) in an Android-specific file. Maybe
encrypted_media_messages_android.h.

[qinmin, 2013/09/18 00:45:44]

ok, removed the include. Duplicated the enum and added the compile asserts

+#include "ipc/ipc_message_macros.h"
+#include "media/base/android/media_codec_bridge.h"
+#include "media/base/android/media_drm_bridge.h"
+
+using content::BrowserThread;
+using media::MediaCodecBridge;
+using media::MediaDrmBridge;
+
+namespace chrome {
+
+// Check whether the available codecs are supported.
+static SupportedCodecs GetSupportedCodecs(
+    SupportedCodecs supported_codecs, bool video_composition_allowed) {

[ddorwin, 2013/09/17 22:29:08]

I think the naming is backwards. The parameter should be requested_codecs and
the local should be supported_codecs.

[ddorwin, 2013/09/17 22:29:08]

is_video_composition_allowed
^^^

This doesn't seem to indicate what we're asking. is_video_compositable?

But we really want to get orthogonal sets. For true, we want as many as
possible. For false, we want only those not in the first set. Is that what this
does or do we get overlapping sets? For audio, I guess we would have
overlapping. Hmm. I guess we can handle this at a higher level.

Back to the naming, it may really be video_must_be_compositable or something
like that.

[qinmin, 2013/09/18 00:45:44]

Done.

[qinmin, 2013/09/18 00:45:44]

Done.

+  SupportedCodecs codecs = NO_SUPPORTED_CODECS;
+  if ((supported_codecs & WEBM_VP8_AND_VORBIS) &&

[ddorwin, 2013/09/17 22:29:08]

Until Android supports encrypted WebM and we can check this, you should always
return false.

[qinmin, 2013/09/18 00:45:44]

Done.

+      MediaCodecBridge::CanDecode("vorbis", !video_composition_allowed) &&

[ddorwin, 2013/09/17 22:29:08]

video_composition_allowed doesn't really apply to audio.

Note that this logic is temporary anyway until secure composition is allowed.
You probably need a TODO (maybe pointing to a bug) here.

[qinmin, 2013/09/18 00:45:44]

the composition flag don't affect audio. Anyway, changed to false. 

+      MediaCodecBridge::CanDecode("vp8", !video_composition_allowed)) {
+    codecs = static_cast<SupportedCodecs>(codecs | WEBM_VP8_AND_VORBIS);
+  }
+
+#if defined(USE_PROPRIETARY_CODECS)
+  if ((supported_codecs & MP4_AAC) &&
+      MediaCodecBridge::CanDecode("mp4a", !video_composition_allowed)) {

[ddorwin, 2013/09/17 22:29:08]

Same.

[qinmin, 2013/09/18 00:45:44]

Done.

+    codecs = static_cast<SupportedCodecs>(codecs | MP4_AAC);
+  }
+
+  if ((supported_codecs & MP4_AVC1) &&
+      MediaCodecBridge::CanDecode("avc1", !video_composition_allowed)) {
+    codecs = static_cast<SupportedCodecs>(codecs | MP4_AVC1);
+  }
+#endif  // defined(USE_PROPRIETARY_CODECS)
+
+  return codecs;
+}
+
+EncryptedMediaMessageFilterAndroid::EncryptedMediaMessageFilterAndroid() {}
+
+EncryptedMediaMessageFilterAndroid::~EncryptedMediaMessageFilterAndroid() {}
+
+bool EncryptedMediaMessageFilterAndroid::OnMessageReceived(
+    const IPC::Message& message, bool* message_was_ok) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP_EX(
+      EncryptedMediaMessageFilterAndroid, message, *message_was_ok)
+    IPC_MESSAGE_HANDLER(ChromeViewHostMsg_GetSupportedKeySystems,
+                        OnGetSupportedKeySystems)
+    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP_EX()
+  return handled;
+}
+
+void EncryptedMediaMessageFilterAndroid::OnGetSupportedKeySystems(
+    const SupportedKeySystemRequest& request,
+    SupportedKeySystemResponse* response) {
+  if (!MediaDrmBridge::IsAvailable() || !MediaCodecBridge::IsAvailable())
+    return;
+
+  if (!MediaDrmBridge::IsCryptoSchemeSupported(request.uuid, ""))

[ddorwin, 2013/09/17 22:29:08]

TODO: Check container types based on codecs in request?

[qinmin, 2013/09/18 00:45:44]

Done.

+    return;
+
+  response->uuid = request.uuid;
+  // TODO(qinmin): check composition is supported or not.
+  response->compositing_codecs =
+      GetSupportedCodecs(request.supported_codecs, true);
+  response->non_compositing_codecs =
+      GetSupportedCodecs(request.supported_codecs, false);
+}
+
+}  // namespace chrome