Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Unified Diff: chrome/browser/expected_install_modules_win.cc

Issue 23513049: Implement install module verification metric. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge and final nits. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/expected_install_modules_win.cc
diff --git a/chrome/browser/expected_install_modules_win.cc b/chrome/browser/expected_install_modules_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..cd51ea48c3be93941dad7ca32641331e16f43e7c
--- /dev/null
+++ b/chrome/browser/expected_install_modules_win.cc
@@ -0,0 +1,33 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/expected_install_modules_win.h"
+#include "base/files/file_path.h"
+#include "base/strings/string_util.h"
+
+// DO NOT REORDER THESE ELEMENTS. Their index is used as an ID in metrics
sky 2013/09/19 20:54:36 Can we use strings in the reporting to avoid havin
erikwright (departed) 2013/09/24 17:33:51 These are UMA metrics we are talking about. To sen
+// reporting.
+extern const wchar_t* kExpectedInstallModules[] = {
+ L"chrome.dll",
+ L"icudt.dll",
+ L"chrome_frame_helper.dll",
+ L"d3dcompiler_46.dll",
+ L"libglesv2.dll",
+ L"metro_driver.dll",
+ L"pdf.dll",
+ L"widevinecdmadapter.dll",
+ L"chrome_child.dll",
+ L"d3dcompiler_43.dll",
+ L"ffmpegsumo.dll",
+ L"libegl.dll",
+ L"libpeerconnection.dll",
+ L"npchrome_frame.dll",
+ L"ppgooglenaclpluginchrome.dll",
+ L"xinput1_3.dll",
+ NULL
+};
+
+std::wstring CanonicalizeModuleName(const std::wstring& module_name) {
+ return StringToLowerASCII(base::FilePath(module_name).BaseName().value());
+}

Powered by Google App Engine
This is Rietveld 408576698