Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3501)

Unified Diff: chrome/browser/install_module_verifier_win.cc

Issue 23513049: Implement install module verification metric. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reviewer comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/install_module_verifier_win.cc
diff --git a/chrome/browser/install_module_verifier_win.cc b/chrome/browser/install_module_verifier_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b03074240eb8c7fca2e23b9b7980f81e81ab5fff
--- /dev/null
+++ b/chrome/browser/install_module_verifier_win.cc
@@ -0,0 +1,97 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/install_module_verifier_win.h"
+
+#include <set>
+#include <string>
+#include "base/basictypes.h"
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/metrics/sparse_histogram.h"
+#include "base/values.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/enumerate_modules_model_win.h"
+#include "chrome/browser/expected_install_modules_win.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/notification_source.h"
+
+namespace {
+
+void OnModuleMatch(unsigned int module_id) {
+ UMA_HISTOGRAM_SPARSE_SLOWLY("InstallVerifier.ModuleMatch", module_id);
+}
+
+class InstallModuleVerifier : public content::NotificationObserver {
+ public:
+ InstallModuleVerifier() {
+ notification_registrar_.Add(this,
+ chrome::NOTIFICATION_MODULE_LIST_ENUMERATED,
+ content::NotificationService::AllSources());
+ }
+ virtual void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) OVERRIDE {
+ EnumerateModulesModel* model =
+ content::Source<EnumerateModulesModel>(source).ptr();
+ scoped_ptr<base::ListValue> module_list(model->GetModuleList());
+
+ if (module_list.get()) {
+ VerifyInstalledModules(module_list.get(), base::Bind(&OnModuleMatch));
+ }
+ delete this;
+ }
+
+ private:
+ content::NotificationRegistrar notification_registrar_;
+ DISALLOW_COPY_AND_ASSIGN(InstallModuleVerifier);
+};
+
+} // namespace
+
+void InitiateInstalledModuleVerification() {
+ scoped_ptr<base::ListValue> module_list(
+ EnumerateModulesModel::GetInstance()->GetModuleList());
+ if (module_list.get()) {
+ VerifyInstalledModules(module_list.get(),
+ base::Bind(&OnModuleMatch));
+ } else {
+ // Will delete itself when scan results are available.
+ new InstallModuleVerifier();
+ EnumerateModulesModel::GetInstance()->ScanNow();
+ }
+}
+
+void VerifyInstalledModules(
+ base::ListValue* module_list,
+ const base::Callback<void(unsigned int)>& delegate) {
+ std::set<std::string> module_name_digests;
MAD 2013/09/16 00:26:16 digest -> canonical?
erikwright (departed) 2013/09/16 20:04:55 Done.
+ for (size_t i = 0; i < module_list->GetSize(); ++i) {
+ base::DictionaryValue* module_dictionary = NULL;
+ if (!module_list->GetDictionary(i, &module_dictionary))
+ continue;
+ ModuleEnumerator::ModuleType module_type =
+ ModuleEnumerator::LOADED_MODULE;
+ if (!module_dictionary->GetInteger(
+ "type", reinterpret_cast<int*>(&module_type)) ||
+ module_type != ModuleEnumerator::LOADED_MODULE) {
+ continue;
+ }
+ std::string module_name;
+ if (!module_dictionary->GetString("name", &module_name))
+ continue;
+
+ std::string module_name_digest = CanonicalizeModuleName(module_name);
MAD 2013/09/16 00:26:16 digest -> canonical?
erikwright (departed) 2013/09/16 20:04:55 Done.
+ module_name_digests.insert(module_name_digest);
+ }
+ for (size_t i = 0; kExpectedInstallModules[i] != 0; ++i) {
+ if (module_name_digests.find(kExpectedInstallModules[i]) !=
+ module_name_digests.end()) {
+ delegate.Run(i);
+ }
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698