Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5041)

Unified Diff: chrome/browser/install_module_verifier_unittest_win.cc

Issue 23513049: Implement install module verification metric. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Additional tests. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/install_module_verifier_unittest_win.cc
diff --git a/chrome/browser/install_module_verifier_unittest_win.cc b/chrome/browser/install_module_verifier_unittest_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..eefbe15862bd0fc2ffcf226d0295a3ff954b4f1c
--- /dev/null
+++ b/chrome/browser/install_module_verifier_unittest_win.cc
@@ -0,0 +1,145 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/install_module_verifier_win.h"
+
+#include <set>
+#include <string>
+#include <vector>
+
+#include "base/bind.h"
+#include "base/md5.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chrome/browser/enumerate_modules_model_win.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+void MockCallback(std::vector<unsigned int>* reported_indexes,
+ size_t module_index) {
+ reported_indexes->push_back(module_index);
+}
+
+void AddModule(base::ListValue* list,
+ ModuleEnumerator::ModuleType type,
+ const std::string& name) {
+ scoped_ptr<base::DictionaryValue> data(new DictionaryValue());
+ data->SetInteger("type", type);
+ data->SetString("name", name);
+ list->Append(data.release());
+}
+
+} // namespace
+
+TEST(InstallModuleVerifierTest, ExtractLoadedModuleNameDigests) {
+ std::set<std::string> loaded_module_name_digests;
+ scoped_ptr<base::ListValue> list(new ListValue());
+ ExtractLoadedModuleNameDigests(*list, &loaded_module_name_digests);
+ ASSERT_TRUE(loaded_module_name_digests.empty());
+ // WinSock modules are ignored.
+ AddModule(list.get(),
+ ModuleEnumerator::SHELL_EXTENSION, "winsock_module.dll");
+ // Shell Extension modules are ignored.
+ AddModule(
+ list.get(),
+ ModuleEnumerator::WINSOCK_MODULE_REGISTRATION, "shell_extension.dll");
+ AddModule(list.get(), ModuleEnumerator::LOADED_MODULE, "fancy_pants.dll");
+ AddModule(list.get(), ModuleEnumerator::LOADED_MODULE, "chrome.dll");
+ ExtractLoadedModuleNameDigests(*list, &loaded_module_name_digests);
+ ASSERT_EQ(2, loaded_module_name_digests.size());
+ ASSERT_NE(loaded_module_name_digests.end(),
+ loaded_module_name_digests.find(base::MD5String("chrome.dll")));
+ ASSERT_NE(loaded_module_name_digests.end(),
+ loaded_module_name_digests.find(
+ base::MD5String("fancy_pants.dll")));
+}
+
+TEST(InstallModuleVerifierTest, VerifyModules) {
+ std::set<std::string> loaded_module_name_digests;
+ std::vector<size_t> reported_indexes;
+
+ VerifyModules(loaded_module_name_digests,
+ AdditionalModules(),
+ base::Bind(&MockCallback, base::Unretained(&reported_indexes)));
+ ASSERT_TRUE(reported_indexes.empty());
+
+ // Expected, Loaded modules are reported.
+ loaded_module_name_digests.insert(base::MD5String("chrome.dll"));
+ // Unexpected modules are ignored.
+ loaded_module_name_digests.insert(base::MD5String("fancy_pants.dll"));
+ VerifyModules(loaded_module_name_digests,
+ AdditionalModules(),
+ base::Bind(&MockCallback, base::Unretained(&reported_indexes)));
+ ASSERT_EQ(1, reported_indexes.size());
+ ASSERT_EQ(1u, reported_indexes[0]); // Well-known ID for chrome.dll.
+ reported_indexes.clear();
+
+ // AdditionalModules can be used to detect other modules.
+ AdditionalModules additional_modules;
+ std::string fancy_pants_md5_digest(base::MD5String("fancy_pants.dll"));
+ additional_modules.push_back(
+ std::make_pair(123u, base::StringPiece(fancy_pants_md5_digest)));
+ VerifyModules(loaded_module_name_digests,
+ additional_modules,
+ base::Bind(&MockCallback, base::Unretained(&reported_indexes)));
+ ASSERT_EQ(2, reported_indexes.size());
+ ASSERT_EQ(1u, reported_indexes[0]); // Well-known ID for chrome.dll.
+ ASSERT_EQ(123u, reported_indexes[1]);
+ reported_indexes.clear();
+
+ // TODO(erikwright): Verify case-insensitive.
+}
+
+TEST(InstallModuleVerifierTest, ParseAdditionalModules) {
+ std::vector<std::pair<size_t, base::StringPiece> > additional_modules;
+
+ ParseAdditionalModules(base::StringPiece(), &additional_modules);
+ ASSERT_EQ(0u, additional_modules.size());
+
+ ParseAdditionalModules("hello", &additional_modules);
+ ASSERT_EQ(0u, additional_modules.size());
+ ParseAdditionalModules("hello world", &additional_modules);
+ ASSERT_EQ(0u, additional_modules.size());
+ ParseAdditionalModules("hello world\nfoo bar", &additional_modules);
+ ASSERT_EQ(0u, additional_modules.size());
+ ParseAdditionalModules("123 world\nfoo bar", &additional_modules);
+ ASSERT_EQ(0u, additional_modules.size());
+ ParseAdditionalModules("hello 0123456789abcdef0123456789abcdef\nfoo bar",
+ &additional_modules);
+ ASSERT_EQ(0u, additional_modules.size());
+ ParseAdditionalModules("123 0123456789abcdef0123456789abcdef\nfoo bar",
+ &additional_modules);
+ ASSERT_EQ(1u, additional_modules.size());
+ ASSERT_EQ(123u, additional_modules[0].first);
+ ASSERT_EQ("0123456789abcdef0123456789abcdef", additional_modules[0].second);
+ additional_modules.clear();
+
+ ParseAdditionalModules("123 0123456789abcdef0123456789abcdef\n"
+ "456 DEADBEEFDEADBEEF\n"
+ "789 DEADBEEFDEADBEEFDEADBEEFDEADBEEF\n"
+ "\n"
+ "\n"
+ "321 BAADCAFEBAADCAFEBAADCAFEBAADCAFE\n",
+ &additional_modules);
+ ASSERT_EQ(3u, additional_modules.size());
+ ASSERT_EQ(123u, additional_modules[0].first);
+ ASSERT_EQ("0123456789abcdef0123456789abcdef", additional_modules[0].second);
+ ASSERT_EQ(789u, additional_modules[1].first);
+ ASSERT_EQ("DEADBEEFDEADBEEFDEADBEEFDEADBEEF", additional_modules[1].second);
+ ASSERT_EQ(321u, additional_modules[2].first);
+ ASSERT_EQ("BAADCAFEBAADCAFEBAADCAFEBAADCAFE", additional_modules[2].second);
+ additional_modules.clear();
+
+ ParseAdditionalModules("\n"
+ "123 0123456789abcdef0123456789abcdef\n"
+ "321 BAADCAFEBAADCAFEBAADCAFEBAADCAFE",
+ &additional_modules);
+ ASSERT_EQ(2u, additional_modules.size());
+ ASSERT_EQ(123u, additional_modules[0].first);
+ ASSERT_EQ("0123456789abcdef0123456789abcdef", additional_modules[0].second);
+ ASSERT_EQ(321u, additional_modules[1].first);
+ ASSERT_EQ("BAADCAFEBAADCAFEBAADCAFEBAADCAFE", additional_modules[1].second);
+ additional_modules.clear();
+}

Powered by Google App Engine
This is Rietveld 408576698