Implement install module verification metric.

chrome/browser/expected_install_modules_win.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/expected_install_modules_win.h"
+#include "base/strings/string_util.h"
+
+// Do not reorder these elements. Their index is used as an ID in metrics
+// reporting.

[robertshield, 2013/09/16 15:07:21]

Would an array of (module, id) pairs be less prone to accidental reordering?
Something like:

static const struct {
  const char* name;
  const int id;
} kExpectedInstallModules[] = {
  { "chrome.dll", 0 },
  ...
};

[robertshield, 2013/09/17 17:06:59]

Let me know what you think of the above.

[erikwright (departed), 2013/09/17 17:20:52]

Sorry for forgetting to reply here.

I'm not convinced it's any better. You have the risk of copy-paste error in that
case.

I'll do it if you feel strongly it's better. Seems mildly more complex for
unclear gain to me.

[robertshield, 2013/09/17 17:28:02]

Fair enough. My theory is that the copy paste error will seem wrong to someone
whose OCD triggers an allergic reaction at the sight of {xx, 0}, {xx, 2}, {xx,
1}, {xx, 3}. i.e. most of us :-)

I can see the complexity argument though, so it's fine to leave it as is, but in
that case please make THE COMMENT SHOUT a bit to make it slightly harder to
miss.

+extern const char* kExpectedInstallModules[] = {
+  "chrome.dll",
+  "icudt.dll",
+  "chrome_frame_helper.dll",
+  "d3dcompiler_46.dll",
+  "libglesv2.dll",
+  "metro_driver.dll",
+  "pdf.dll",
+  "widevinecdmadapter.dll",
+  "chrome_child.dll",
+  "d3dcompiler_43.dll",
+  "ffmpegsumo.dll",
+  "libegl.dll",
+  "libpeerconnection.dll",
+  "npchrome_frame.dll",
+  "ppgooglenaclpluginchrome.dll",
+  "xinput1_3.dll",
+  0
+};
+
+std::string CanonicalizeModuleName(const std::string& module_name) {
+  std::string result;
+  size_t slash = module_name.rfind('/');

[robertshield, 2013/09/16 15:07:21]

Where does this get its module names from? This looks un-windowsy. Also,
FilePath::BaseName?

[erikwright (departed), 2013/09/16 20:04:55]

Done.

+  if (slash != std::string::npos)
+    result = module_name.substr(slash + 1);
+  else
+    result = module_name;
+  StringToLowerASCII(&result);
+  return result;
+}