Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: chrome/browser/expected_install_modules_win.cc

Issue 23513049: Implement install module verification metric. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reviewer comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/expected_install_modules_win.h"
6 #include "base/strings/string_util.h"
7
8 // Do not reorder these elements. Their index is used as an ID in metrics
9 // reporting.
10 extern const char* kExpectedInstallModules[] = {
11 "chrome.dll",
12 "icudt.dll",
13 "chrome_frame_helper.dll",
14 "d3dcompiler_46.dll",
15 "libglesv2.dll",
16 "metro_driver.dll",
17 "pdf.dll",
18 "widevinecdmadapter.dll",
19 "chrome_child.dll",
20 "d3dcompiler_43.dll",
21 "ffmpegsumo.dll",
22 "libegl.dll",
23 "libpeerconnection.dll",
24 "npchrome_frame.dll",
25 "ppgooglenaclpluginchrome.dll",
26 "xinput1_3.dll",
27 0
28 };
29
30 std::string CanonicalizeModuleName(const std::string& module_name) {
31 std::string result;
32 size_t slash = module_name.rfind('/');
MAD 2013/09/16 14:42:43 On windows, you should be looking for '\'... And
erikwright (departed) 2013/09/16 20:04:55 Done.
33 if (slash != std::string::npos)
34 result = module_name.substr(slash + 1);
35 else
36 result = module_name;
37 StringToLowerASCII(&result);
38 return result;
39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698