chrome/browser/install_module_verifier_win.h - Issue 23513049: Implement install module verification metric.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/install_module_verifier_win.h

Issue 23513049: Implement install module verification metric. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/install_module_verifier_unittest_win.cc ('K') | « chrome/browser/install_module_verifier_unittest_win.cc ('k') | chrome/browser/install_module_verifier_win.cc » ('j') | chrome/browser/install_module_verifier_win.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_INSTALL_MODULE_VERIFIER_WIN_H_

	6 #define CHROME_BROWSER_INSTALL_MODULE_VERIFIER_WIN_H_

	7

	8 #include "base/callback_forward.h"

	9

	10 namespace base {

	11 class ListValue;

	12 } // namespace base

	13

	14 void InitiateInstalledModuleVerification();
	erikwright (departed) 2013/09/13 14:47:07 Add comments. Add comments. robertshield 2013/09/13 17:26:05 naming bikeshedding: how about "BeginModuleVerific naming bikeshedding: how about "BeginModuleVerification" and "VerifyModules" as shorter-and-as-descriptive names? robertshield 2013/09/16 15:07:21 No bites on the bikeshedding? Show quoted text On 2013/09/13 17:26:05, robertshield wrote: > naming bikeshedding: how about "BeginModuleVerification" and "VerifyModules" as > shorter-and-as-descriptive names? No bites on the bikeshedding? erikwright (departed) 2013/09/16 20:04:55 Done. Show quoted text On 2013/09/13 17:26:05, robertshield wrote: > naming bikeshedding: how about "BeginModuleVerification" and "VerifyModules" as > shorter-and-as-descriptive names? Done. erikwright (departed) 2013/09/16 20:04:55 Done. Show quoted text On 2013/09/16 15:07:21, robertshield wrote: > On 2013/09/13 17:26:05, robertshield wrote: > > naming bikeshedding: how about "BeginModuleVerification" and "VerifyModules" > as > > shorter-and-as-descriptive names? > > No bites on the bikeshedding? Done.
	15 void VerifyInstalledModules(base::ListValue* module_list,

	16 const base::Callback<void(unsigned int)>& delegate);

	17

	18 #endif // CHROME_BROWSER_INSTALL_MODULE_VERIFIER_WIN_H_

OLD	NEW