Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Side by Side Diff: src/apinatives.js

Issue 23513048: Don't lookup the cache for the result of Function::New (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 function InstantiateFunction(data, name) { 65 function InstantiateFunction(data, name) {
66 // We need a reference to kApiFunctionCache in the stack frame 66 // We need a reference to kApiFunctionCache in the stack frame
67 // if we need to bail out from a stack overflow. 67 // if we need to bail out from a stack overflow.
68 var cache = kApiFunctionCache; 68 var cache = kApiFunctionCache;
69 var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset); 69 var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset);
70 var isFunctionCached = 70 var isFunctionCached =
71 (serialNumber in cache) && (cache[serialNumber] != kUninitialized); 71 (serialNumber in cache) && (cache[serialNumber] != kUninitialized);
72 if (!isFunctionCached) { 72 if (!isFunctionCached) {
73 try { 73 try {
74 cache[serialNumber] = null;
75 var fun = %CreateApiFunction(data); 74 var fun = %CreateApiFunction(data);
76 if (name) %FunctionSetName(fun, name); 75 if (name) %FunctionSetName(fun, name);
77 var flags = %GetTemplateField(data, kApiFlagOffset); 76 var flags = %GetTemplateField(data, kApiFlagOffset);
78 var doNotCache = flags & (1 << kDoNotCacheBit); 77 var doNotCache = flags & (1 << kDoNotCacheBit);
79 if (!doNotCache) cache[serialNumber] = fun; 78 if (!doNotCache) cache[serialNumber] = fun;
80 if (flags & (1 << kRemovePrototypeBit)) { 79 if (flags & (1 << kRemovePrototypeBit)) {
81 %FunctionRemovePrototype(fun); 80 %FunctionRemovePrototype(fun);
82 } else { 81 } else {
83 var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset); 82 var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset);
84 // Note: Do not directly use an object template as a condition, our 83 // Note: Do not directly use an object template as a condition, our
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 obj, name, getter, setter, attribute, access_control); 131 obj, name, getter, setter, attribute, access_control);
133 } else { 132 } else {
134 throw "Bad properties array"; 133 throw "Bad properties array";
135 } 134 }
136 i += length + 1; 135 i += length + 1;
137 } 136 }
138 } finally { 137 } finally {
139 if (requires_access_checks) %EnableAccessChecks(obj); 138 if (requires_access_checks) %EnableAccessChecks(obj);
140 } 139 }
141 } 140 }
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698