Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 23513045: MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. (Closed)

Created:
7 years, 3 months ago by palfia
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. Port r16688 (fcae0bcf) Original commit message: The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they contain the same fields. The field order will be: holder isolate return value default value return value data this This step 1 reorders the PropertyCallbackInfo fields. BUG= R=gergely@homejinni.com Committed: https://code.google.com/p/v8/source/detail?r=16697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M src/mips/stub-cache-mips.cc View 7 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 3 months ago (2013-09-12 23:56:25 UTC) #1
kisg
LGTM
7 years, 3 months ago (2013-09-13 00:02:37 UTC) #2
palfia
7 years, 3 months ago (2013-09-13 00:04:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16697 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698