chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac_unittest.mm - Issue 23513039: Replace animated tab audio indicator with static tab audio indicator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac_unittest.mm

Issue 23513039: Replace animated tab audio indicator with static tab audio indicator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review comments from sky@. Also, rebased. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #import "chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac.h"

6

7 #include "base/mac/scoped_nsobject.h"

8 #include "base/message_loop/message_loop.h"

9 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"

10

11 class TabAudioIndicatorViewMacTest : public CocoaTest {

12 protected:

13 TabAudioIndicatorViewMacTest() {

14 base::scoped_nsobject<TabAudioIndicatorViewMac> view(

15 [[TabAudioIndicatorViewMac alloc]

16 initWithFrame:NSMakeRect(0, 0, 16, 16)]);

17 view_ = view.get();

18 [[test_window() contentView] addSubview:view_];

19

20 base::scoped_nsobject<NSImage> image(

21 [[NSImage alloc] initWithSize:NSMakeSize(16, 16)]);

22 [image lockFocus];

23 NSRectFill(NSMakeRect(0, 0, 16, 16));

24 [image unlockFocus];

25

26 [view_ setBackgroundImage:image];

27 [view_ setIsPlayingAudio:YES];

28 }

29

30 TabAudioIndicatorViewMac* view_;

31 base::MessageLoopForUI message_loop_; // Needed for gfx::LinearAnimation.

32

33 private:

34 DISALLOW_COPY_AND_ASSIGN(TabAudioIndicatorViewMacTest);

35 };

36

37 TEST_VIEW(TabAudioIndicatorViewMacTest, view_)

OLD	NEW