Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: build/android/pylib/constants.py

Issue 23513022: android: Point EMULATOR_SDK_ROOT to a location inside the repository. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Defines a set of constants shared by test runners and other scripts.""" 5 """Defines a set of constants shared by test runners and other scripts."""
6 6
7 import collections 7 import collections
8 import os 8 import os
9 import subprocess 9 import subprocess
10 import sys 10 import sys
11 11
12 12
13 DIR_SOURCE_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), 13 DIR_SOURCE_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__),
14 os.pardir, os.pardir, os.pardir)) 14 os.pardir, os.pardir, os.pardir))
15 ISOLATE_DEPS_DIR = os.path.join(DIR_SOURCE_ROOT, 'isolate_deps_dir') 15 ISOLATE_DEPS_DIR = os.path.join(DIR_SOURCE_ROOT, 'isolate_deps_dir')
16 EMULATOR_SDK_ROOT = os.path.abspath(os.path.join(DIR_SOURCE_ROOT, os.pardir, 16 EMULATOR_SDK_ROOT = os.path.abspath(os.path.join(DIR_SOURCE_ROOT,
17 os.pardir)) 17 'third_party'))
Peter Beverloo 2013/09/09 14:05:50 This probably needs 'android_tools' and 'sdk' as a
Raphael Kubo da Costa (rakuco) 2013/09/09 14:08:04 Not really; the places which still reference EMULA
bulach 2013/09/09 18:59:52 would suggest change this to point to android_tool
18 18
19 # TODO(craigdh): Remove these once references have been removed downstream. 19 # TODO(craigdh): Remove these once references have been removed downstream.
20 CHROME_PACKAGE = 'com.google.android.apps.chrome' 20 CHROME_PACKAGE = 'com.google.android.apps.chrome'
21 CHROME_ACTIVITY = 'com.google.android.apps.chrome.Main' 21 CHROME_ACTIVITY = 'com.google.android.apps.chrome.Main'
22 22
23 CHROME_STABLE_PACKAGE = 'com.android.chrome' 23 CHROME_STABLE_PACKAGE = 'com.android.chrome'
24 CHROME_BETA_PACKAGE = 'com.chrome.beta' 24 CHROME_BETA_PACKAGE = 'com.chrome.beta'
25 25
26 LEGACY_BROWSER_PACKAGE = 'com.google.android.browser' 26 LEGACY_BROWSER_PACKAGE = 'com.google.android.browser'
27 LEGACY_BROWSER_ACTIVITY = 'com.android.browser.BrowserActivity' 27 LEGACY_BROWSER_ACTIVITY = 'com.android.browser.BrowserActivity'
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 except OSError: 144 except OSError:
145 print >> sys.stderr, 'No adb found in $PATH, fallback to checked in binary.' 145 print >> sys.stderr, 'No adb found in $PATH, fallback to checked in binary.'
146 return os.path.join(ANDROID_SDK_ROOT, 'platform-tools', 'adb') 146 return os.path.join(ANDROID_SDK_ROOT, 'platform-tools', 'adb')
147 147
148 148
149 ADB_PATH = _GetADBPath() 149 ADB_PATH = _GetADBPath()
150 150
151 # Exit codes 151 # Exit codes
152 ERROR_EXIT_CODE = 1 152 ERROR_EXIT_CODE = 1
153 WARNING_EXIT_CODE = 88 153 WARNING_EXIT_CODE = 88
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698