Issue 23513014: Worked around bug with gtest filters on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23513014: Worked around bug with gtest filters on Linux. (Closed)

Created:
7 years, 3 months ago by phoglund_chromium

Modified:
7 years, 3 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Worked around bug with gtest filters on Linux. We have temporarily disabled all WebRTC content_browsertests on Linux. This causes our custom build steps to hang because they no longer select any test cases on Linux, triggering bug 285051. This works around that bug so we don't have to disable the step and restart all our masters. BUG=285051 TBR=tommi@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221185

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	content/browser/media/webrtc_browsertest.cc	View		1 chunk	+7 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

lgtm https://codereview.chromium.org/23513014/diff/1/content/browser/media/webrtc_browsertest.cc File content/browser/media/webrtc_browsertest.cc (right): https://codereview.chromium.org/23513014/diff/1/content/browser/media/webrtc_browsertest.cc#newcode54 content/browser/media/webrtc_browsertest.cc:54: class WebrtcWorkaroundBugWithEmptyFilter: public ContentBrowserTest {}; space before :

7 years, 3 months ago (2013-09-04 10:26:30 UTC) #2

phoglund_chromium

7 years, 3 months ago (2013-09-04 14:02:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r221185 (presubmit successful).

Expand Messages | Collapse Messages