Have Text constructor take a Document reference in argument

Have Text constructor take a Document reference in argument

Have Text constructor take a Document reference in argument as it can
never be NULL. Most callers already have a reference so this avoids
having to convert them into pointers.

BUG=281400
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157251

[dglazkov, 2013-09-04 19:00:24]

lgtm, thought it looks like Text doesn't ever modify Document. Could it be const
Document&?

[do-not-use, 2013-09-04 19:59:44]

On 2013/09/04 19:00:24, Dimitri Glazkov wrote:
> lgtm, thought it looks like Text doesn't ever modify Document. Could it be
const
> Document&?

Text passes the Document along the the CharacterData constructor which takes a
"TreeScope*" in argument, not a "const TreeScope*". The document is passed all
the way up to Node which then exposes it as:
Document& document() const;

[dglazkov, 2013-09-04 20:22:55]

ok.

[commit-bot: I haz the power, 2013-09-04 20:28:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23513013/1

[commit-bot: I haz the power, 2013-09-04 20:28:38]

Failed to apply patch for Source/core/html/track/WebVTTParser.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/html/track/WebVTTParser.cpp
  Hunk #1 FAILED at 330.
  Hunk #2 succeeded at 346 (offset 1 line).
  Hunk #3 succeeded at 484 (offset 1 line).
  Hunk #4 succeeded at 501 (offset 1 line).
  Hunk #5 succeeded at 534 (offset 1 line).
  1 out of 5 hunks FAILED -- saving rejects to file
Source/core/html/track/WebVTTParser.cpp.rej

Patch:       Source/core/html/track/WebVTTParser.cpp
Index: Source/core/html/track/WebVTTParser.cpp
diff --git a/Source/core/html/track/WebVTTParser.cpp
b/Source/core/html/track/WebVTTParser.cpp
index
4b2dfc22fc6148a2aba985b4302aba35f032b9a3..a7cbee636654dca81a5f47982d0d56bfa4025421
100644
--- a/Source/core/html/track/WebVTTParser.cpp
+++ b/Source/core/html/track/WebVTTParser.cpp
@@ -330,11 +330,12 @@ PassRefPtr<DocumentFragment> 
WebVTTParser::createDocumentFragmentFromCueText(co
 
     ASSERT(m_scriptExecutionContext->isDocument());
     Document* document = toDocument(m_scriptExecutionContext);
+    ASSERT(document);
 
     RefPtr<DocumentFragment> fragment = DocumentFragment::create(document);
 
     if (!text.length()) {
-        fragment->parserAppendChild(Text::create(document, ""));
+        fragment->parserAppendChild(Text::create(*document, ""));
         return fragment;
     }
 
@@ -345,7 +346,7 @@ PassRefPtr<DocumentFragment> 
WebVTTParser::createDocumentFragmentFromCueText(co
     m_languageStack.clear();
     SegmentedString content(text);
     while (m_tokenizer->nextToken(content, m_token))
-        constructTreeFromToken(document);
+        constructTreeFromToken(*document);
 
     return fragment.release();
 }
@@ -483,7 +484,7 @@ static WebVTTNodeType tokenToNodeType(WebVTTToken& token)
     return WebVTTNodeTypeNone;
 }
 
-void WebVTTParser::constructTreeFromToken(Document* document)
+void WebVTTParser::constructTreeFromToken(Document& document)
 {
     QualifiedName tagName(nullAtom, AtomicString(m_token.name()),
xhtmlNamespaceURI);
 
@@ -500,7 +501,7 @@ void WebVTTParser::constructTreeFromToken(Document*
document)
         RefPtr<WebVTTElement> child;
         WebVTTNodeType nodeType = tokenToNodeType(m_token);
         if (nodeType != WebVTTNodeTypeNone)
-            child = WebVTTElement::create(nodeType, document);
+            child = WebVTTElement::create(nodeType, &document);
         if (child) {
             if (m_token.classes().size() > 0)
                 child->setAttribute(classAttr,
AtomicString(m_token.classes()));
@@ -533,7 +534,7 @@ void WebVTTParser::constructTreeFromToken(Document*
document)
         String
charactersString(StringImpl::create8BitIfPossible(m_token.characters()));
         double time = collectTimeStamp(charactersString, &position);
         if (time != malformedTime)
-           
m_currentNode->parserAppendChild(ProcessingInstruction::create(document,
"timestamp", charactersString));
+           
m_currentNode->parserAppendChild(ProcessingInstruction::create(&document,
"timestamp", charactersString));
         break;
     }
     default:

[commit-bot: I haz the power, 2013-09-04 21:24:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23513013/12001

[commit-bot: I haz the power, 2013-09-05 01:04:35]

Change committed as 157251