pkg/serialization/lib/src/serialization_helpers.dart - Issue 23513010: Make HashMap constructor a factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/serialization/lib/src/serialization_helpers.dart

Issue 23513010: Make HashMap constructor a factory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/serialization/lib/src/serialization_helpers.dart

diff --git a/pkg/serialization/lib/src/serialization_helpers.dart b/pkg/serialization/lib/src/serialization_helpers.dart

index 015215c4aede12be2b49a200b7bac7704b2fe6ca..ec898574730d0cbba7d0ad886adf306d80a6cb88 100644

--- a/pkg/serialization/lib/src/serialization_helpers.dart

+++ b/pkg/serialization/lib/src/serialization_helpers.dart

@@ -209,9 +209,11 @@ class _IdentityMapKey {

* wrapped objects. It also treats equal primitive values as identical

* to conserve space.

-class IdentityMap<K, V> extends HashMap<K, V> {

+class IdentityMap<K, V> extends LinkedHashMap<K, V> {

// TODO(alanknight): Replace with a system identity-based map once

// one is available. Issue 4161.

+// TODO(lrn): Replace with identity map when custom hash maps are introduced

+// (which is soon).

// Check before wrapping because some methods may call others, e.g. on

// dart2js putIfAbsent calls containsKey, so without this we wrap forever.

« no previous file with comments | « no previous file | runtime/lib/collection_patch.dart » ('j') | no next file with comments »