Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 23513004: remove old style callbacks (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : inlined a function used once #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -746 lines) Patch
M include/v8.h View 25 chunks +0 lines, -97 lines 0 comments Download
M src/api.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/api.cc View 1 14 chunks +64 lines, -347 lines 0 comments Download
M src/arguments.h View 4 chunks +23 lines, -91 lines 0 comments Download
M src/arguments.cc View 2 chunks +26 lines, -112 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 4 chunks +7 lines, -13 lines 2 comments Download
M src/builtins.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/d8.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/handles.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M src/isolate.h View 3 chunks +0 lines, -9 lines 0 comments Download
M src/isolate.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/objects.cc View 13 chunks +28 lines, -24 lines 0 comments Download
M src/stub-cache.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-lockers.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dcarney
there's a follow up round to clean up some arch-specific stuff, but this gets rid ...
7 years, 3 months ago (2013-08-27 08:40:35 UTC) #1
Sven Panne
LGTM if you explain the TODOs in the platform files. https://codereview.chromium.org/23513004/diff/4001/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://codereview.chromium.org/23513004/diff/4001/src/arm/stub-cache-arm.cc#newcode906 ...
7 years, 3 months ago (2013-08-27 09:12:43 UTC) #2
dcarney
On 2013/08/27 09:12:43, Sven Panne wrote: > LGTM if you explain the TODOs in the ...
7 years, 3 months ago (2013-08-27 09:15:21 UTC) #3
Sven Panne
On 2013/08/27 09:15:21, dcarney wrote: > basically, there are a whole bunch of functions that ...
7 years, 3 months ago (2013-08-27 09:18:08 UTC) #4
dcarney
> So this is just a reminder for a follow-up CL removing that parameter, right? ...
7 years, 3 months ago (2013-08-27 09:22:36 UTC) #5
dcarney
7 years, 3 months ago (2013-08-27 11:48:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r16354 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698