Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2351283004: [Mac] Fix for the fullscreen toolbar issue with Active Spaces (Closed)

Created:
4 years, 3 months ago by spqchan
Modified:
4 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix for the fullscreen toolbar issue with Active Spaces Made sure that the menubar state is correct when the active space is changed BUG=647111 Committed: https://crrev.com/8a690e5e200f90623e69083917fea4677e11e660 Cr-Commit-Position: refs/heads/master@{#420645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm View 4 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
spqchan
PTAL
4 years, 3 months ago (2016-09-21 00:06:44 UTC) #3
Robert Sesek
How does this work with multiple monitors and the user specifying their preference for the ...
4 years, 3 months ago (2016-09-21 20:32:13 UTC) #4
spqchan
On 2016/09/21 20:32:13, Robert Sesek wrote: > How does this work with multiple monitors and ...
4 years, 3 months ago (2016-09-23 02:07:03 UTC) #5
Robert Sesek
LGTM On 2016/09/23 02:07:03, spqchan wrote: > On 2016/09/21 20:32:13, Robert Sesek wrote: > > ...
4 years, 3 months ago (2016-09-23 15:35:54 UTC) #6
spqchan
On 2016/09/23 15:35:54, Robert Sesek wrote: > LGTM > > On 2016/09/23 02:07:03, spqchan wrote: ...
4 years, 3 months ago (2016-09-23 16:43:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351283004/1
4 years, 3 months ago (2016-09-23 16:44:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 17:25:50 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 17:29:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a690e5e200f90623e69083917fea4677e11e660
Cr-Commit-Position: refs/heads/master@{#420645}

Powered by Google App Engine
This is Rietveld 408576698