Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2351253002: Ozone Demo: Fix NOTREACHED assert when SwapBuffersAsync is not supported (Closed)

Created:
4 years, 3 months ago by fwang
Modified:
4 years, 3 months ago
Reviewers:
rjkroege
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone Demo: Fix NOTREACHED assert when SwapBuffersAsync is not supported Currently, the ozone demo may raise the following assertion on some platforms (e.g. X11) when SwapBuffersAsync is called in gl_renderer or surfaceless_gl_renderer: ERROR:gl_surface.cc(75) NOTREACHED() hit. A verification is added in this CL to ensure that SwapBuffersAsync is supported and otherwise terminate the program with a fatal error. R=rjkroege@chromium.org BUG=None Committed: https://crrev.com/0054fa9f56bab60b5a7e411a84ee454d6b9a38fe Cr-Commit-Position: refs/heads/master@{#420036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/ozone/demo/ozone_demo.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fwang
PTAL
4 years, 3 months ago (2016-09-20 18:57:23 UTC) #2
rjkroege
lgtm
4 years, 3 months ago (2016-09-21 13:24:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351253002/1
4 years, 3 months ago (2016-09-21 13:27:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 13:34:37 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 13:37:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0054fa9f56bab60b5a7e411a84ee454d6b9a38fe
Cr-Commit-Position: refs/heads/master@{#420036}

Powered by Google App Engine
This is Rietveld 408576698