Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2351213002: Re-add size parameter to WebNotificationImage for notification center (Closed)

Created:
4 years, 3 months ago by tdanderson
Modified:
4 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add size parameter to WebNotificationImage for notification center Re-add the size parameter that was removed in https://codereview.chromium.org/2324913002/, as this is needed for correct icon sizing from external applications or extensions. BUG=641168 TEST=manual Committed: https://crrev.com/1b08bb8ac6e2b3dfed928e1803bb60c6d419361a Cr-Commit-Position: refs/heads/master@{#420035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M ash/common/system/web_notification/web_notification_tray.cc View 4 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tdanderson
yoshiki@, please take a look. Does this solve the issue? I have no easy way ...
4 years, 3 months ago (2016-09-20 15:27:42 UTC) #4
yoshiki
Thanks! LGTM.
4 years, 3 months ago (2016-09-21 10:39:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351213002/1
4 years, 3 months ago (2016-09-21 13:28:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 13:33:39 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 13:35:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b08bb8ac6e2b3dfed928e1803bb60c6d419361a
Cr-Commit-Position: refs/heads/master@{#420035}

Powered by Google App Engine
This is Rietveld 408576698