tests/compiler/dart2js/bad_loop_test.dart - Issue 23512008: Call asyncEnd only on success.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/bad_loop_test.dart

Issue 23512008: Call asyncEnd only on success. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/bad_loop_test.dart

diff --git a/tests/compiler/dart2js/bad_loop_test.dart b/tests/compiler/dart2js/bad_loop_test.dart

index 65629a453e8fb1bac366d2f252aec162f166f61e..8a86fd6c17383b331f94bf7d6c06e930ce29e820 100644

--- a/tests/compiler/dart2js/bad_loop_test.dart

+++ b/tests/compiler/dart2js/bad_loop_test.dart

@@ -37,12 +37,11 @@ main() {

libraryRoot,

packageRoot,

['--analyze-only']);

- asyncStart();

- compiler.run(Uri.parse('memory:main.dart')).then((_) {

+ asyncTest(() => compiler.run(Uri.parse('memory:main.dart')).then((_) {

Expect.isTrue(compiler.compilationFailed);

Expect.equals(5, errorCount);

Expect.equals(1, warningCount);

- }).whenComplete(() => asyncEnd());

+ }));

}

const Map MEMORY_SOURCE_FILES = const {