tests/compiler/dart2js/analyze_only_test.dart - Issue 23512008: Call asyncEnd only on success.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/analyze_only_test.dart

Issue 23512008: Call asyncEnd only on success. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/analyze_only_test.dart

diff --git a/tests/compiler/dart2js/analyze_only_test.dart b/tests/compiler/dart2js/analyze_only_test.dart

index 67bbeb8d4f7330e699c5372133d410b932df3ca5..818149aca185b239e59d535d8377fffd21493472 100644

--- a/tests/compiler/dart2js/analyze_only_test.dart

+++ b/tests/compiler/dart2js/analyze_only_test.dart

@@ -45,7 +45,7 @@ runCompiler(String main, List<String> options,

onValue(code, errors, warnings);

}, onError: (e) {

throw 'Compilation failed';

- }).whenComplete(() => asyncEnd());

+ }).then(asyncSuccess);

}

main() {