Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: tests/utils/recursive_import_test.dart

Issue 23512008: Call asyncEnd only on success. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/utils/dummy_compiler_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // Test of "recursive" imports using the dart2js compiler API. 5 // Test of "recursive" imports using the dart2js compiler API.
6 6
7 import "package:expect/expect.dart"; 7 import "package:expect/expect.dart";
8 import "package:async_helper/async_helper.dart"; 8 import "package:async_helper/async_helper.dart";
9 import 'dart:async'; 9 import 'dart:async';
10 import '../../sdk/lib/_internal/compiler/compiler.dart'; 10 import '../../sdk/lib/_internal/compiler/compiler.dart';
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 provider, handler); 121 provider, handler);
122 result.then((String code) { 122 result.then((String code) {
123 Expect.isNull(code); 123 Expect.isNull(code);
124 Expect.isTrue(10 < count); 124 Expect.isTrue(10 < count);
125 // Two warnings for each time RECURSIVE_MAIN is read, except the 125 // Two warnings for each time RECURSIVE_MAIN is read, except the
126 // first time. 126 // first time.
127 Expect.equals(2 * (count - 1), warningCount); 127 Expect.equals(2 * (count - 1), warningCount);
128 Expect.equals(1, errorCount); 128 Expect.equals(1, errorCount);
129 }, onError: (e) { 129 }, onError: (e) {
130 throw 'Compilation failed'; 130 throw 'Compilation failed';
131 }).whenComplete(() => asyncEnd()); 131 }).then(asyncSuccess);
132 } 132 }
OLDNEW
« no previous file with comments | « tests/utils/dummy_compiler_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698