Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: tests/utils/dummy_compiler_test.dart

Issue 23512008: Call asyncEnd only on success. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/compiler/dart2js/mirrors_test.dart ('k') | tests/utils/recursive_import_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions= 4 // VMOptions=
5 // VMOptions=--print-object-histogram 5 // VMOptions=--print-object-histogram
6 6
7 // Smoke test of the dart2js compiler API. 7 // Smoke test of the dart2js compiler API.
8 library dummy_compiler; 8 library dummy_compiler;
9 9
10 import 'dart:async'; 10 import 'dart:async';
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 compile(new Uri(scheme: 'main'), 109 compile(new Uri(scheme: 'main'),
110 new Uri(scheme: 'lib', path: '/'), 110 new Uri(scheme: 'lib', path: '/'),
111 new Uri(scheme: 'package', path: '/'), 111 new Uri(scheme: 'package', path: '/'),
112 provider, handler); 112 provider, handler);
113 result.then((String code) { 113 result.then((String code) {
114 if (code == null) { 114 if (code == null) {
115 throw 'Compilation failed'; 115 throw 'Compilation failed';
116 } 116 }
117 }, onError: (e) { 117 }, onError: (e) {
118 throw 'Compilation failed'; 118 throw 'Compilation failed';
119 }).whenComplete(() => asyncEnd()); 119 }).then(asyncSuccess);
120 } 120 }
OLDNEW
« no previous file with comments | « tests/compiler/dart2js/mirrors_test.dart ('k') | tests/utils/recursive_import_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698