tools/perf/benchmarks/pica.py - Issue 23512005: BrowserOptions.extra_browser_args is now a set.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/benchmarks/pica.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from telemetry import test	5 from telemetry import test

6 from telemetry.page import page_measurement	6 from telemetry.page import page_measurement

7	7

8 class PicaMeasurement(page_measurement.PageMeasurement):	8 class PicaMeasurement(page_measurement.PageMeasurement):

9 def CustomizeBrowserOptions(self, options):	9 def CustomizeBrowserOptions(self, options):

10 # Needed for native custom elements (document.register)	10 # Needed for native custom elements (document.register)

11 options.AppendExtraBrowserArg('--enable-experimental-web-platform-features')	11 options.AppendExtraBrowserArgs(

	12 '--enable-experimental-web-platform-features')

12	13

13 def MeasurePage(self, _, tab, results):	14 def MeasurePage(self, _, tab, results):

14 result = int(tab.EvaluateJavaScript('__pica_load_time'))	15 result = int(tab.EvaluateJavaScript('__pica_load_time'))

15 results.Add('Total', 'ms', result)	16 results.Add('Total', 'ms', result)

16	17

17	18

18 class Pica(test.Test):	19 class Pica(test.Test):

19 test = PicaMeasurement	20 test = PicaMeasurement

20 page_set = 'page_sets/pica.json'	21 page_set = 'page_sets/pica.json'

OLD	NEW