Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3369)

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_view.mm

Issue 2351183003: [Mac] Avoid "adding unknown subview" warning. (Closed)
Patch Set: Address feedback. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
index 2329650aa54f457d6daf25a517b8faa527c83809..3a1fbdcef1bdd61c884c3c0a2240083405f4c649 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
@@ -378,7 +378,11 @@
return nil;
}
- NSView* rootView = [[[self window] contentView] superview];
+ NSView* rootView = [[self window] contentView];
+ if (base::mac::IsAtMostOS10_10()) {
+ rootView = [rootView superview];
+ }
+
Class nsVisualEffectViewClass = NSClassFromString(@"NSVisualEffectView");
DCHECK(nsVisualEffectViewClass);
for (NSView* view in [rootView subviews]) {
« no previous file with comments | « chrome/browser/ui/cocoa/full_size_content_window.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698