Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3214)

Unified Diff: chrome/browser/ui/webui/signin/signin_error_handler.h

Issue 2351173004: Display local signin error without browser and record the path of selected profile in user manager. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/signin_error_handler.h
diff --git a/chrome/browser/ui/webui/signin/signin_error_handler.h b/chrome/browser/ui/webui/signin/signin_error_handler.h
index 3de30be7ce9488441f4df941514f1385e73c186f..1d882d1212a3234bd38732c6927af509c30b625a 100644
--- a/chrome/browser/ui/webui/signin/signin_error_handler.h
+++ b/chrome/browser/ui/webui/signin/signin_error_handler.h
@@ -19,7 +19,7 @@ class ListValue;
class SigninErrorHandler : public content::WebUIMessageHandler {
public:
- SigninErrorHandler() {}
+ static SigninErrorHandler* Create(bool is_system_profile);
pastarmovj 2016/09/21 08:44:10 I think a comment why you need this factory functi
zmin 2016/09/21 16:40:04 Done.
~SigninErrorHandler() override {}
// content::WebUIMessageHandler:
@@ -33,6 +33,7 @@ class SigninErrorHandler : public content::WebUIMessageHandler {
}
protected:
+ SigninErrorHandler() {}
pastarmovj 2016/09/21 08:44:10 nit: new line after the constructor.
zmin 2016/09/21 16:40:04 Done.
// Handles "switch" message from the page. No arguments.
// This message is sent when the user switches to the existing profile of the
// same username used for signin.
@@ -53,7 +54,7 @@ class SigninErrorHandler : public content::WebUIMessageHandler {
// a single integer value for the height the native view should resize to.
virtual void HandleInitializedWithSize(const base::ListValue* args);
- void CloseDialog();
+ virtual void CloseDialog();
private:
const ProfileAttributesEntry* duplicate_profile_entry_ = nullptr;
@@ -61,4 +62,15 @@ class SigninErrorHandler : public content::WebUIMessageHandler {
DISALLOW_COPY_AND_ASSIGN(SigninErrorHandler);
};
+class SigninErrorWithoutBrowserHandler : public SigninErrorHandler {
pastarmovj 2016/09/21 08:44:10 Comment this class please.
zmin 2016/09/21 16:40:04 Done.
+ public:
+ SigninErrorWithoutBrowserHandler();
+
+ protected:
+ void CloseDialog() override;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(SigninErrorWithoutBrowserHandler);
+};
+
#endif // CHROME_BROWSER_UI_WEBUI_SIGNIN_SIGNIN_ERROR_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698