Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/ui/views/profiles/user_manager_view.h

Issue 2351173004: Display local signin error without browser and record the path of selected profile in user manager. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/user_manager_view.h
diff --git a/chrome/browser/ui/views/profiles/user_manager_view.h b/chrome/browser/ui/views/profiles/user_manager_view.h
index 8de45f806d8665055199dc5dc3866e9cf6aeb670..8c46341806c347f3c74aa69fcfa9781a2b515415 100644
--- a/chrome/browser/ui/views/profiles/user_manager_view.h
+++ b/chrome/browser/ui/views/profiles/user_manager_view.h
@@ -31,6 +31,9 @@ class ReauthDelegate : public views::DialogDelegateView,
// UserManager::BaseReauthDialogDelegate:
void CloseReauthDialog() override;
+ // Display the local error message inside login window.
+ void DisplayErrorMessage();
+
private:
ReauthDelegate();
@@ -50,7 +53,7 @@ class ReauthDelegate : public views::DialogDelegateView,
int GetDialogButtons() const override;
views::View* GetInitiallyFocusedView() override;
- UserManagerView* parent_; // Not owned.
+ UserManagerView* parent_; // Not owned.
views::WebView* web_view_;
const std::string email_address_;
@@ -97,6 +100,12 @@ class UserManagerView : public views::DialogDelegateView {
// Hides the reauth dialog if it is showing.
void HideReauthDialog();
+ // Display local sign in error message withou browser.
sky 2016/09/20 23:30:19 without. What do you mean by local?
zmin 2016/09/21 00:09:35 Local means the error not from Gaia(i..e password
zmin 2016/09/21 16:40:04 Remove "local" as it may cause confusion
+ void DisplayErrorMessage();
+
+ void SetSigninProfilePath(const base::FilePath profile_path);
sky 2016/09/20 23:30:19 const &
zmin 2016/09/21 16:40:04 Done.
+ base::FilePath GetSigninProfilePath();
+
private:
friend class ReauthDelegate;
friend std::default_delete<UserManagerView>;
@@ -129,6 +138,8 @@ class UserManagerView : public views::DialogDelegateView {
std::unique_ptr<ScopedKeepAlive> keep_alive_;
base::Time user_manager_started_showing_;
+ base::FilePath signin_profile_path_;
+
DISALLOW_COPY_AND_ASSIGN(UserManagerView);
};

Powered by Google App Engine
This is Rietveld 408576698