Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2351173002: Prune CreateVisiblePositionDeprecated from FrameCaret::absoluteCaretBounds (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune CreateVisiblePositionDeprecated from FrameCaret::absoluteCaretBounds BUG=647219 Committed: https://crrev.com/0f4f1f5cb173cdc9cfb05b408e1cc4b2161d8f26 Cr-Commit-Position: refs/heads/master@{#419748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-20 13:40:36 UTC) #4
yosin_UTC9
lgtm
4 years, 3 months ago (2016-09-20 13:56:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351173002/1
4 years, 3 months ago (2016-09-20 13:57:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 14:02:28 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 14:04:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f4f1f5cb173cdc9cfb05b408e1cc4b2161d8f26
Cr-Commit-Position: refs/heads/master@{#419748}

Powered by Google App Engine
This is Rietveld 408576698