Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2351153002: Site Settings Desktop: Minor fix to make the All Sites list reflect changes. (Closed)

Created:
4 years, 3 months ago by Finnur
Modified:
4 years, 3 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: Minor fix to make the All Sites list reflect changes. The |category| sent down will never be ALL_SITES, but it should also be notified of changes. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6d5f6eeae4e582503342c13efe22927494955b0b Cr-Commit-Position: refs/heads/master@{#419887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/site_settings/site_list.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Finnur
4 years, 3 months ago (2016-09-20 12:13:23 UTC) #5
dschuyler
lgtm
4 years, 3 months ago (2016-09-20 18:23:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351153002/1
4 years, 3 months ago (2016-09-20 22:58:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 23:06:14 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 23:09:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d5f6eeae4e582503342c13efe22927494955b0b
Cr-Commit-Position: refs/heads/master@{#419887}

Powered by Google App Engine
This is Rietveld 408576698