DevTools FE uploader: fix sending mail to multiple recipients

DevTools FE uploader: fix sending mail to multiple recipients

Previously, the FE uploader wasn't properly sending notification emails
to multiple recipients because the to_address must be a list otherwise it
will be treated as a list with 1 email address. [1]

[1] https://docs.python.org/2/library/smtplib.html

BUG=none
R=dgozman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=0483ccda4eac4e032ad831a6823980b15a95ab76

[chenwilliam, 2016-09-20 21:49:30]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2016-09-20 21:49:31]

PTAL. I tried it on the GCE instance and I've gotten an email from the uploader.

https://codereview.chromium.org/2351133003/diff/1/gce/uploader_mail.py
File gce/uploader_mail.py (left):

https://codereview.chromium.org/2351133003/diff/1/gce/uploader_mail.py#oldcode25
gce/uploader_mail.py:25: message['To'] = config['TO_ADDRESS']
This needs to be a string because it's an email header. The 'To' header is only
used for display, but doesn't actually determine who receives the email.

https://bytes.com/topic/python/answers/472868-sending-emails-list-recipients

[dgozman, 2016-09-22 20:53:29]

lgtm. Thanks!

https://codereview.chromium.org/2351133003/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/2351133003/diff/1/.gitignore#newcode1
.gitignore:1: *.pyc
What has changed here?

[chenwilliam, 2016-09-22 22:10:14]

https://codereview.chromium.org/2351133003/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/2351133003/diff/1/.gitignore#newcode1
.gitignore:1: *.pyc
On 2016/09/22 20:53:29, dgozman wrote:
> What has changed here?

It's weird how diffs show up but if you look at the unified diff
(https://codereview.chromium.org/2351133003/patch/1/10001?context=10&column_wi...)
this was actually a new .gitignore file that git treats as a "copy" from
gae/.gitignore. I just added a new patchset to delete the gae/.gitignore since
that rule will be covered by the .gitignore in the root of the repo.

[chenwilliam, 2016-09-23 22:18:54]

Description was changed from

==========
DevTools FE uploader: fix sending mail to multiple recipients

Previously, the FE uploader wasn't properly sending notification emails
to multiple recipients because the to_address must be a list otherwise it
will be treated as a list with 1 email address. [1]

[1] https://docs.python.org/2/library/smtplib.html

BUG=none
==========

to

==========
DevTools FE uploader: fix sending mail to multiple recipients

Previously, the FE uploader wasn't properly sending notification emails
to multiple recipients because the to_address must be a list otherwise it
will be treated as a list with 1 email address. [1]

[1] https://docs.python.org/2/library/smtplib.html

BUG=none
R=dgozman@chromium.org

Committed:
https://src.chromium.org/viewvc/chrome?view=rev&revision=0483ccda4eac4e032ad8...
==========

[chenwilliam, 2016-09-23 22:18:56]

Committed patchset #2 (id:20001) manually as
0483ccda4eac4e032ad831a6823980b15a95ab76 (presubmit successful).